Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] fix: Fixed deployment details tags not appearing when tags is empty #17220

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[UI v2] fix: Fixed deployment details tags not appearing when tags is empty #17220

merged 1 commit into from
Feb 20, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 20, 2025 •
edited
Loading

Fixed deployment details tags not appearing when tags is empty

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 20, 2025
devinvillarosa
devinvillarosa commented Feb 20, 2025
View reviewed changes
ui-v2/src/components/deployments/deployment-metadata.tsx
@@ -114,7 +114,7 @@ export const DeploymentMetadata = ({ deployment }: DeploymentMetadataProps) => {
{
field: "Tags",
ComponentValue: () =>
deployment.tags ? (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original logic wouldn't render anything if deployment.tags === []

@devinvillarosa devinvillarosa marked this pull request as ready for review February 20, 2025 20:19
@devinvillarosa devinvillarosa merged commit ed0cf01 into main Feb 20, 2025
16 checks passed
@devinvillarosa devinvillarosa deleted the fix-tags-none branch February 20, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@devangrose devangrose Awaiting requested review from devangrose

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @pleek91