[UI v2] feat: Re-organizes flow runs data table components and to use a provider for row selection capabilities #17216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5183359 to
370918e
Compare
… a provider for row selection capabilities
370918e to
ea62c35
Compare
devinvillarosa
commented
Feb 20, 2025
There was a problem hiding this comment.
Fixes bug from mismatched values
devinvillarosa
commented
Feb 20, 2025
|
|
||
| const selectedRows = Object.keys(rowSelection); | ||
| if (rowSelectionCtx) { |
There was a problem hiding this comment.
Here's the logic to give the data-table the selectable UX. Dependent if its wrapped with a row-selection provider
devinvillarosa
commented
Feb 20, 2025
| <ViewComponent key={value} /> | ||
| ))} | ||
| </Tabs> | ||
| ); | ||
| }; | ||
|
|
||
| function useBuildTabOptions(deployment: Deployment) { | ||
| return useMemo( |
There was a problem hiding this comment.
Needed to memo-ize this to prevent the entire tab component to re-render and losing input focus
devangrose
approved these changes
Feb 20, 2025
|
Thanks for cleaning this up! |
devinvillarosa
added a commit
that referenced
this pull request
Feb 20, 2025
… a provider for row selection capabilities (#17216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-organizes flow runs data table components and to use a provider for row selection capabilities
Uploading Screen Recording 2025-02-20 at 10.21.10 AM.mov…
Checklist
<link to issue>"mint.json.