Surfaces pull step errors as independent log messages #17214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to increase user's visibility into any problems with
dependency installations and code pulls, we want to make sure that the
output is clear and actionable in their logs. Today, when we get a
step excution error, we are showing that as a full traceback, including
the underlying
__cause__
, which can be quite verbose for theuninitiated.
Here we get the string representation of that exception message as a
separate
ERROR
log just before we re-raise it. This comes out in theflow run logs as a clean error, like: