Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes client extras and moves them to top level dependencies #17202

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Feb 19, 2025

Closes #17197

@github-actions github-actions bot added the bug Something isn't working label Feb 19, 2025
Comment on lines -101 to -119
markdown-docs = [
"pytest-markdown-docs>=0.6.0",
"prefect[aws]",
"prefect[azure]",
"prefect[bitbucket]",
"prefect[dask]",
"prefect[databricks]",
# "prefect[dbt]",
"prefect[email]",
"prefect[gcp]",
"prefect[github]",
"prefect[gitlab]",
"prefect[kubernetes]",
"prefect[ray]",
"prefect[shell]",
"prefect[slack]",
"prefect[snowflake]",
"prefect[sqlalchemy]",
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are managed by a dependency group lower in the file.

Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #17202 will not alter performance

Comparing fix-client-dependencies (7359ed1) with main (8e802bb)

Summary

✅ 2 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@desertaxle desertaxle marked this pull request as ready for review February 19, 2025 20:55
@desertaxle desertaxle requested a review from cicdw as a code owner February 19, 2025 20:55
@desertaxle desertaxle merged commit 5ceb3ad into main Feb 19, 2025
51 checks passed
@desertaxle desertaxle deleted the fix-client-dependencies branch February 19, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.4.2+ Circular dependency. Package 'prefect[client]' is listed as a dependency of itself.
2 participants