Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds delete flow run mutation #17188

Merged
merged 1 commit into from
Feb 19, 2025
Merged

[UI v2] feat: Adds delete flow run mutation #17188

merged 1 commit into from
Feb 19, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 19, 2025 •
edited
Loading

Adds delete flow run mutation

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 19, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 19, 2025 06:41
@devinvillarosa devinvillarosa force-pushed the add-use-delete-flow-runs-dialog branch 2 times, most recently from 576a2b8 to 9aa2d24 Compare February 19, 2025 07:13
pleek91
pleek91 reviewed Feb 19, 2025
View reviewed changes
ui-v2/src/components/flow-runs/data-table/use-delete-flow-runs-dialog.ts Outdated
import { useDeleteConfirmationDialog } from "@/components/ui/delete-confirmation-dialog";
import { useToast } from "@/hooks/use-toast";

export const useDeleteDeploymentConfirmationDialog = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be delete flow run not delete deployment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, need to update from copying and pasting. Thanks

@devinvillarosa devinvillarosa force-pushed the add-use-delete-flow-runs-dialog branch from 9aa2d24 to 5b174b0 Compare February 19, 2025 15:35
@devinvillarosa devinvillarosa merged commit 3d30411 into main Feb 19, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the add-use-delete-flow-runs-dialog branch February 19, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@devangrose devangrose Awaiting requested review from devangrose

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @pleek91