Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try improved cancelled_flow_query #17095

Merged
merged 2 commits into from
Feb 20, 2025
Merged

try improved cancelled_flow_query #17095

merged 2 commits into from
Feb 20, 2025

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Feb 11, 2025 •
edited
Loading

closes #17080

@zzstoatzz zzstoatzz force-pushed the cancelled-flow-query branch from 3f4f8a3 to ff02d57 Compare February 11, 2025 18:26
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #17095 will not alter performance

Comparing cancelled-flow-query (0642129) with main (955378c)

Summary

✅ 2 untouched benchmarks

@github-actions github-actions bot added the bug Something isn't working label Feb 11, 2025
@zzstoatzz zzstoatzz force-pushed the cancelled-flow-query branch from 9b93c3e to 0642129 Compare February 11, 2025 19:45
@zzstoatzz zzstoatzz mentioned this pull request Feb 11, 2025
Closed
@zzstoatzz zzstoatzz marked this pull request as ready for review February 11, 2025 19:48
desertaxle
desertaxle approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zzstoatzz zzstoatzz merged commit b6b3339 into main Feb 20, 2025
49 checks passed
@zzstoatzz zzstoatzz deleted the cancelled-flow-query branch February 20, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cancelled_flow_query very slow
2 participants
@zzstoatzz @desertaxle