Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where schedules without a slug or active raise a 500 #17091

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

desertaxle
Copy link
Member

This PR ensures that we default to active=True when schedules are recreated via a call to the POST /deployments endpoint. This preserves the behavior exhibited prior to the introduction of deployment schedule slugs.

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #17091 will not alter performance

Comparing fix-create-deployment-on-update-no--slug (c086bbb) with main (3c5112d)

Summary

✅ 2 untouched benchmarks

@desertaxle desertaxle merged commit b19a7cb into main Feb 11, 2025
49 checks passed
@desertaxle desertaxle deleted the fix-create-deployment-on-update-no--slug branch February 11, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants