Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds createDeploymentFlowRun mutation #17047

Merged
merged 1 commit into from
Feb 7, 2025
Merged

[UI v2] feat: Adds createDeploymentFlowRun mutation #17047

merged 1 commit into from
Feb 7, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 7, 2025 •
edited
Loading

Adds createDeploymentFlowRun mutation. This is needed for the deployment quick run button

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to: #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 7, 2025
devinvillarosa
devinvillarosa commented Feb 7, 2025
View reviewed changes
ui-v2/src/api/flow-runs/index.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to add the hook here, even tho its part of /deployments.
This is because this mutation affects the flow-run queries

@devinvillarosa devinvillarosa marked this pull request as ready for review February 7, 2025 18:15
@devinvillarosa devinvillarosa force-pushed the add-deployment-create-flow-run-mutation branch from a8f3a1d to 2d2e70a Compare February 7, 2025 18:16
@devinvillarosa devinvillarosa force-pushed the add-deployment-create-flow-run-mutation branch from 2d2e70a to 172da4d Compare February 7, 2025 18:42
@devinvillarosa devinvillarosa merged commit a175a0a into main Feb 7, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the add-deployment-create-flow-run-mutation branch February 7, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

@devangrose devangrose devangrose approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devinvillarosa @pleek91 @devangrose