Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migration downgrades on deployment schedule table #17044

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix migration downgrades on deployment schedule table #17044

merged 2 commits into from
Feb 7, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 7, 2025

Closes #17036

@github-actions github-actions bot added development Tech debt, refactors, CI, tests, and other related work. migration labels Feb 7, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #17044 will not alter performance

Comparing foreign-keys-off (de8f48d) with main (e38b549)

Summary

✅ 2 untouched benchmarks

@cicdw cicdw mentioned this pull request Feb 7, 2025
Merged
desertaxle
desertaxle approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cicdw cicdw merged commit cb20788 into main Feb 7, 2025
46 checks passed
@cicdw cicdw deleted the foreign-keys-off branch February 7, 2025 17:34
kevingrismore pushed a commit that referenced this pull request Feb 7, 2025
@cicdw @kevingrismore
Fix migration downgrades on deployment schedule table (#17044)
6b9dd4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@zangell44 zangell44 zangell44 approved these changes

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work. migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix weird flake in integration tests with sqlite
3 participants
@cicdw @desertaxle @zangell44