Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor results and result records to improve circular import situation #17031

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 6, 2025

This PR doesn't solve any one problem in and of itself, but it does untangle one common cycle in the circular import tale (ref: #16387)

The next tangle I plan to tackle is to move client.schemas.objects.State.to_state_create to a standalone utility (in general I think we should avoid methods that do type conversions like this), which will avoid the circular import of client objects importing client actions, which in turn import client objects.

@cicdw cicdw added the development Tech debt, refactors, CI, tests, and other related work. label Feb 6, 2025
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #17031 will not alter performance

Comparing defer-eventing-import (bc29c8c) with main (cb20788)

Summary

✅ 2 untouched benchmarks

@cicdw cicdw mentioned this pull request Feb 7, 2025
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Good pattern to break a cycle, pull it out to a new module.

@cicdw cicdw merged commit 94e59bd into main Feb 7, 2025
46 checks passed
@cicdw cicdw deleted the defer-eventing-import branch February 7, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants