-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support anonymous volumes in docker
work pool
#17022
Conversation
9765cdc
to
a59ca0e
Compare
@@ -276,9 +277,10 @@ async def test_uses_volumes_setting( | |||
"/home/user:/home/docker:rw", | |||
"C:\\path\\on\\windows:/path/in/container", | |||
"\\\\host\\share:/path/in/container", | |||
"/data", # anonymous volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for taking care of this so swiftly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstring nit, otherwise LGTM
Co-authored-by: Chris White <chris@prefect.io>
Co-authored-by: Chris White <chris@prefect.io>
closes #17017
adds ability to specify anonymous volumes in a docker work pool