Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support anonymous volumes in docker work pool #17022

Merged
merged 3 commits into from
Feb 7, 2025
Merged

support anonymous volumes in docker work pool #17022

merged 3 commits into from
Feb 7, 2025

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Feb 6, 2025

closes #17017

adds ability to specify anonymous volumes in a docker work pool

@github-actions github-actions bot added the bug Something isn't working label Feb 6, 2025
@zzstoatzz zzstoatzz added the integrations Related to integrations with other services label Feb 6, 2025
@zzstoatzz zzstoatzz marked this pull request as ready for review February 6, 2025 21:48
@@ -276,9 +277,10 @@ async def test_uses_volumes_setting(
"/home/user:/home/docker:rw",
"C:\\path\\on\\windows:/path/in/container",
"\\\\host\\share:/path/in/container",
"/data", # anonymous volume
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new case

Copy link

@anze3db anze3db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for taking care of this so swiftly!

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring nit, otherwise LGTM

Co-authored-by: Chris White <chris@prefect.io>
@zzstoatzz zzstoatzz merged commit 3959a3b into main Feb 7, 2025
9 checks passed
@zzstoatzz zzstoatzz deleted the anon-volumes branch February 7, 2025 01:07
kevingrismore pushed a commit that referenced this pull request Feb 7, 2025
Co-authored-by: Chris White <chris@prefect.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integrations Related to integrations with other services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation error when using anonymous volumes
3 participants