Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for updating a deployment's parameter openapi schema #17016

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 6, 2025

In preparation for improving the deployment experience with respect to schedules, this PR allows for deployments to update the parameter openAPI schema and adjusts the server-side validation and testes accordingly.

@cicdw cicdw added the enhancement An improvement of an existing feature label Feb 6, 2025
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #17016 will not alter performance

Comparing patch-deployment-patch (6554dfa) with main (e38b549)

Summary

✅ 2 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have one question about behavior when the schema and parameters are updated together, but it's non-blocking.

@cicdw cicdw merged commit 07e2b9f into main Feb 7, 2025
48 checks passed
@cicdw cicdw deleted the patch-deployment-patch branch February 7, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants