Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Adds npm script to check only typescript types #16995

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 5, 2025

Adds npm script validate:types (same script name from /ui) to only validate typescript.

We currently don't have an npm script that does it. We do have npm run build which does type checking and builds the app.

Adding this command, because before pushing and opening a PR, I would like to validate types on my client. My IDE doesn't always catch all errors

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 5, 2025
@devinvillarosa devinvillarosa force-pushed the add-validate-types-option branch from 2c81a69 to c684669 Compare February 6, 2025 18:09
@pleek91
Copy link
Contributor

pleek91 commented Feb 6, 2025

do we need to build the types or can we just check them? In other projects we use the "noEmit" flag. Not sure if it makes a difference though?

@devinvillarosa
Copy link
Contributor Author

do we need to build the types or can we just check them? In other projects we use the "noEmit" flag. Not sure if it makes a difference though?

ahh let me check if that works

@devinvillarosa devinvillarosa force-pushed the add-validate-types-option branch from c684669 to 4e00f0f Compare February 6, 2025 19:07
@devinvillarosa devinvillarosa merged commit 0f092b5 into main Feb 6, 2025
6 checks passed
@devinvillarosa devinvillarosa deleted the add-validate-types-option branch February 6, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants