Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use retry logic of underlying prefect client properly #16992

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 5, 2025

I noticed that our clients no longer use the dedicated send(...) methods that we built to help with flaky API performance. This PR re-engages that logic.

As stated in the httpx docs, calling client.request is

Equivalent to:

request = client.build_request(...)
response = client.send(request, ...)

This also resolves an undetected bug in which PREFECT_CLIENT_RETRY_EXTRA_CODES was not being used.

@cicdw cicdw added bug Something isn't working enhancement An improvement of an existing feature labels Feb 5, 2025
@aaazzam
Copy link
Collaborator

aaazzam commented Feb 5, 2025

image

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #16992 will not alter performance

Comparing better-worker-error-handling (6d954d5) with main (b634c37)

Summary

✅ 2 untouched benchmarks

@cicdw cicdw merged commit 6bc8e73 into main Feb 5, 2025
48 checks passed
@cicdw cicdw deleted the better-worker-error-handling branch February 5, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants