-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow definition of per-schedule parameters via .serve
and .deploy
#16965
Allow definition of per-schedule parameters via .serve
and .deploy
#16965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small notes - also the other PR was merged so you can rebase
6859d56
to
2d44b3a
Compare
CodSpeed Performance ReportMerging #16965 will not alter performanceComparing Summary
|
6902b7e
to
fa51087
Compare
Co-authored-by: Chris White <chris@prefect.io>
3e145e3
to
328e909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, only question is whether we should complain if you pass both schedule
and schedules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice! This LGTM - note that it also closes #14972
@zzstoatzz, the changes in this PR should raise if both |
aha i must have missed an update - just tested and it LGTM now on that point @desertaxle |
#16965) Co-authored-by: Chris White <chris@prefect.io>
Example:
Closes #14972