Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file exclusion to codeowners #16957

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add file exclusion to codeowners #16957

merged 2 commits into from
Feb 4, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 4, 2025

As we saw on #16921, changes to settings incur a huge review cost in the form of tagging tons of people (unnecessarily).

CODEOWNERS files take into account the last line referencing a file for review requests, so you can effectively "reset" individual files as needed. This PR uses that pattern for settings related file changes that don't need doc-team review.

@cicdw cicdw added the development Tech debt, refactors, CI, tests, and other related work. label Feb 4, 2025
@cicdw cicdw merged commit 0d25aa6 into main Feb 4, 2025
9 checks passed
@cicdw cicdw deleted the tweak-to-codeowners branch February 4, 2025 17:06
kevingrismore pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants