Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] upgrade: Upgrades to tailwind 4 #16886

Merged
merged 9 commits into from
Feb 24, 2025
Merged

[UI v2] upgrade: Upgrades to tailwind 4 #16886

merged 9 commits into from
Feb 24, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 28, 2025

Updates to tailwind 4 following this guide: https://ui.shadcn.com/docs/tailwind-v4

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 28, 2025
@devinvillarosa devinvillarosa force-pushed the migrate-tw-4 branch 2 times, most recently from 5b4f5a3 to 7506dd8 Compare January 28, 2025 23:09
@devinvillarosa devinvillarosa marked this pull request as ready for review January 28, 2025 23:10
@desertaxle
Copy link
Member

Dialogs are a little bit wonky with new Tailwind

Screen.Recording.2025-01-29.at.11.21.32.AM.mov

@devinvillarosa devinvillarosa marked this pull request as draft February 10, 2025 21:37
@devinvillarosa devinvillarosa force-pushed the migrate-tw-4 branch 2 times, most recently from 5107864 to dbb50e6 Compare February 24, 2025 17:44
@devinvillarosa devinvillarosa marked this pull request as ready for review February 24, 2025 18:04
@devinvillarosa
Copy link
Contributor Author

devinvillarosa commented Feb 24, 2025

Dialogs are a little bit wonky with new Tailwind

Screen.Recording.2025-01-29.at.11.21.32.AM.mov

I think it should be resolved now after following the shadcn guide and re-installing the updated component

Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pleek91
Copy link
Contributor

pleek91 commented Feb 24, 2025

Should we switch from postcss to the vite plugin? Recommended by tailwind in their migration doc

https://tailwindcss.com/docs/upgrade-guide#using-vite

@devinvillarosa
Copy link
Contributor Author

Should we switch from postcss to the vite plugin? Recommended by tailwind in their migration doc

https://tailwindcss.com/docs/upgrade-guide#using-vite

Thanks, I've added it in the latest push. For some reason the tailwind upgrade script didn't add it

@devinvillarosa devinvillarosa merged commit 6294b53 into main Feb 24, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the migrate-tw-4 branch February 24, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants