Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds reusable Combobox UI component #16637

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[UI v2] feat: Adds reusable Combobox UI component #16637

merged 1 commit into from
Jan 9, 2025
+285 −14

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 8, 2025 •
edited
Loading

  1. Adds Combobox component that wraps composition of Popper and Command components with built in styling for a consistent Dev experience

  2. Writes simple story on how to use component

Screen.Recording.2025-01-07.at.4.01.27.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

#15512

@devinvillarosa devinvillarosa marked this pull request as ready for review January 8, 2025 00:03
@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 8, 2025
devinvillarosa
devinvillarosa commented Jan 8, 2025
View reviewed changes
ui-v2/src/components/ui/popover.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds fullWidth prop to have popover expand to the full screen.

@devinvillarosa devinvillarosa force-pushed the add-combobox-ui branch 3 times, most recently from a29d1bd to 5a286d9 Compare January 8, 2025 00:28
@devinvillarosa devinvillarosa force-pushed the add-combobox-ui branch 2 times, most recently from 5d56129 to b14248b Compare January 8, 2025 18:24
@devinvillarosa devinvillarosa merged commit e299e5a into main Jan 9, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the add-combobox-ui branch January 9, 2025 18:09
devinvillarosa added a commit that referenced this pull request Jan 10, 2025
@devinvillarosa
[UI v2] feat: Adds reusable Combobox UI component (#16637)
1f114aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle