Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Updates VITE_API_URL to be configured throughout storybook and development #16620

Merged
merged 3 commits into from
Jan 6, 2025
Merged

[UI v2] feat: Updates VITE_API_URL to be configured throughout storybook and development #16620

merged 3 commits into from
Jan 6, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 6, 2025 •
edited
Loading

Configures VITE_API_URL in dev, test, and storybook such that VITE_API_URL will be used regardless of the application's environment.

This should set us up to use MSW in storybook now that API endpoints are no longer hardcoded

Screen.Recording.2025-01-05.at.11.36.55.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 6, 2025
@devinvillarosa devinvillarosa force-pushed the configurable-url branch 2 times, most recently from 4597127 to becdc33 Compare January 6, 2025 07:43
@devinvillarosa devinvillarosa marked this pull request as ready for review January 6, 2025 07:46
desertaxle
desertaxle reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of nits, but overall this makes a lot of sense to me!

ui-v2/tests/utils/handlers.ts Show resolved Hide resolved
ui-v2/tests/utils/handlers.ts Outdated Show resolved Hide resolved
devinvillarosa
devinvillarosa commented Jan 6, 2025
View reviewed changes
ui-v2/package.json Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I use a .env file instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would probably be cleaner and reduce the chance for misconfiguration for devs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, latest push updates to use .env file

ui-v2/tests/api/service.test.ts Show resolved Hide resolved
ui-v2/tests/utils/handlers.ts Show resolved Hide resolved
@devinvillarosa devinvillarosa force-pushed the configurable-url branch 3 times, most recently from 8fcf00f to ffe49c9 Compare January 6, 2025 17:36
desertaxle
desertaxle approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devinvillarosa devinvillarosa merged commit a8628b8 into main Jan 6, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the configurable-url branch January 6, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle