[UI v2] feat: Adds component for change-flow-run-state option #16611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11ebffe to
00ac211
Compare
00ac211 to
c6d48fb
Compare
d522778 to
618969e
Compare
618969e to
d2e07fd
Compare
desertaxle
reviewed
Jan 6, 2025
...ange-flow-run-state-fields/automations-wizard-action-change-flow-run-state-message-field.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks like this file was deleted and not recreated.
There was a problem hiding this comment.
Some of these files got moved as part of automations-wizard-action-type-select.tsx and automations-wizard-action-step.tsx.
I'm trying to figure out how I should write stories & tests since they're part of a form
There was a problem hiding this comment.
Looks like this file was deleted and not recreated.
ui-v2/src/components/automations/automations-wizard/automations-wizard-action-step/index.ts
Outdated
Show resolved
Hide resolved
| onSubmit, | ||
| }: AutomationWizardActionStepProps) => { | ||
| const form = useForm<z.infer<typeof ActionsSchema>>({ | ||
| resolver: zodResolver(ActionsSchema), |
There was a problem hiding this comment.
Should the schema used change based on the action type that is selected?
There was a problem hiding this comment.
When trying this out, I think having
export const ActionsSchema = z.union([
ChangeFlowRunStateSchema,
DeploymentsSchema,
RunDeploymentsSchema,
WorkPoolSchema,
WorkQueueSchema,
AutomationSchema,
SendNotificationSchema,
FlowRunSchema,
]);
in action-type-schemas gives a similar UI. the schema will be based on the type field from type narrowing.
d2e07fd to
9859d87
Compare
2c84b24 to
1916e56
Compare
|
Re-organized folder such that all action related components are in |
1916e56 to
40b742b
Compare
desertaxle
approved these changes
Jan 6, 2025
...utomations/automations-wizard/action-step/action-change-flow-run-state-fields/flow-states.ts
Outdated
Show resolved
Hide resolved
…p/action-change-flow-run-state-fields/flow-states.ts Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
059d29c to
0258ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change flow run's stateScreen.Recording.2025-01-05.at.9.51.07.AM.mov
Checklist
<link to issue>"mint.json.Relates to #15512