Add the ability to scroll an item into view in the virtual scroller #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
znicholasbrown
approved these changes
Oct 28, 2024
Comment on lines
+142
to
145
| function getChunkHeight(index: number): number { | ||
| return props.itemEstimateHeight * chunks.value[index].length | ||
| } | ||
|
|
There was a problem hiding this comment.
Oh wow, we were severely underestimating these heights huh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new utility
getVirtualScrollerwhere you can get access to a virtual scroller instance by its given name (which is now a prop on the virtual scroller component). This way we can grab a scroller at any point in the component tree. The available actions aremakeItemVisible- Accepts an itemKey and forces the chunk that item belongs to to be visiblescrollItemIntoView- Accepts an itemKey and automatically scrolls to that item.