Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add an override property to the sticky root margin composition #1480

Merged

Conversation

znicholasbrown
Copy link
Contributor

This isn't a super elegant solution but this allows applications to provide their own offset to deeply-nested components that are using this composition.

@znicholasbrown znicholasbrown requested a review from a team as a code owner October 23, 2024 18:10
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit b1e67ba
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/67193c2c08031c0008df8355
😎 Deploy Preview https://deploy-preview-1480--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@znicholasbrown znicholasbrown merged commit f3e0645 into main Oct 23, 2024
6 checks passed
@znicholasbrown znicholasbrown deleted the chore/p-list-header/offset-sticky-composition-2024-10-23 branch October 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants