BEM managed by CVA in PButton #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Discussed this sync - there's a bit of cleanup to do here but largely this is the appropriate direction, we'll work out some of the hairier details in the next few days. |
|
@znicholasbrown I think I've addressed the decisions made in Friday OH. |
znicholasbrown
approved these changes
Apr 29, 2024
pleek91
reviewed
Apr 29, 2024
Comment on lines
+69
to
+73
| type ButtonProps = VariantProps<typeof button> | ||
|
|
||
| const props = defineProps<{ | ||
| variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link', | ||
| size?: 'default' | 'sm' | 'lg' | 'icon', | ||
| variant?: ButtonProps['variant'], | ||
| size?: ButtonProps['size'], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves PButton to adopt CVA to manage it's BEM hierarchy.
Along the way, the styles for
selectedare properly handled via aria-selected.This is likely the penultimate PR, which will free us from the ~80 CSS Vars to style buttons.