Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PButton styling #1232

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Simplify PButton styling #1232

merged 2 commits into from
Apr 23, 2024

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Apr 23, 2024

Part of a series of PRs to simplify styling for PButton.

This series of PRs is trying to do two things:

  • reduce the surface area of our design tokens for better maintenance. Right now we have things like --p-color-default-button-bg that is a pointer to 'transparent' and is used in exactly one place.
  • make adding or changing button variants easier. I'd like to make a more uniform interface to our components around sizes (we have small: bool or size: string inconsistently), but our specific styling of PButton and other components makes it incredibly hard to change variants since they create a polynomial number of orthogonal BEM classes to maintain.

wish me luck!

@aaazzam aaazzam requested a review from a team as a code owner April 23, 2024 14:55
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit 14f03a4
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/6627cbd800095400088c12d8
😎 Deploy Preview https://deploy-preview-1232--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pleek91
Copy link
Collaborator

pleek91 commented Apr 23, 2024

right now we have things like --p-color-default-button-bg that is a pointer to 'transparent' and is used in exactly one place.

Yeah I don't think we need all these aliases. If we're using a design token we should use it directly rather making it look like its another token but its actually just an alias.

I'd like to make a more uniform interface to our components around sizes (we have small: bool or size: string inconsistently),

Yessss, idk how we ended up here but I'd love these to be consistent.

@aaazzam aaazzam merged commit a022815 into main Apr 23, 2024
6 checks passed
@aaazzam aaazzam deleted the default-button-styles branch April 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants