Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast lightness palette to a 4% grid #1226

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Cast lightness palette to a 4% grid #1226

merged 1 commit into from
Apr 22, 2024

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Apr 22, 2024

Our design system samples lightness values more or less randomly clustered around increments of 4%.

This PR casts our lightness values to a 4% grid.

    --p-color-bg-0: hsl(var(--p-primary-hue), 6%, 15.88%);
    --p-color-bg-1: hsl(var(--p-primary-hue), 6%, 11.76%);
    --p-color-bg-2: var(--p-color-bg-0);
    --p-color-bg-3: hsl(var(--p-primary-hue), 6%, 20.2%);
    --p-color-bg-floating: hsl(var(--p-primary-hue), 6%, 22.16%);
    --p-color-bg-floating-sticky: hsl(var(--p-primary-hue) 6.67% 11.76% / 0.9);
    --p-color-bg-code: hsl(var(--p-primary-hue), 12.2%, 8.04%);
    --p-color-bg-overlay: hsl(0.0 0.0% 0.0% / 0.5);

becomes

    --p-color-bg-0: hsl(var(--p-primary-hue), 6%, 16%);
    --p-color-bg-1: hsl(var(--p-primary-hue), 6%, 12%);
    --p-color-bg-2: hsl(var(--p-primary-hue), 6%, 16%);
    --p-color-bg-3: hsl(var(--p-primary-hue), 6%, 20%);
    --p-color-bg-floating: hsl(var(--p-primary-hue), 6%, 24%);
    --p-color-bg-floating-sticky: hsl(var(--p-primary-hue) 6% 12% / 0.9);
    --p-color-bg-code: hsl(var(--p-primary-hue), 6%, 8%);
    --p-color-bg-overlay: hsl(0.0 0.0% 0.0% / 0.5);

The color changes here are more-or-less imperceptible, and shouldn't have noticeable changes to users. This is more of a form-over-function PR.

@aaazzam aaazzam requested a review from a team as a code owner April 22, 2024 16:22
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit 9a84726
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/66268eddec3feb00081263ce
😎 Deploy Preview https://deploy-preview-1226--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aaazzam aaazzam merged commit af51cff into main Apr 22, 2024
6 checks passed
@aaazzam aaazzam deleted the primary-is-not-bg branch April 22, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants