Enhancement: Add generics and better slots to PTabs #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
commented
Apr 18, 2024
Comment on lines
-5
to
-7
| // adding defineSlots doesn't match what app.component expects | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment, @typescript-eslint/prefer-ts-expect-error | ||
| // @ts-ignore |
There was a problem hiding this comment.
Interestingly enough, this component doesn't even use defineSlots...
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
commented
Apr 18, 2024
src/components/Tabs/PTabSelect.vue
Outdated
There was a problem hiding this comment.
This components slots were inconsistent with the root PTabs component. Which likely would lead to implementation errors/bugs at some point. Bringing it inline (yay slot types!)
znicholasbrown
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wanted to fix a few issues.
Updating these components to use generics and defineSlots fixes these
Note: There's a weird type issue in the install method for PTabs. I've run into this before and it seems to be related to using defineSlots producing some type other than what app.component wants. But everything seems to work as I'd expect when testing this.