Feature: PCascadePanels
#1175
Merged
Feature: PCascadePanels
#1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
reviewed
Apr 1, 2024
pleek91
reviewed
Apr 2, 2024
pleek91
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new set of utility components/compositions, called Cascade Panels. These components are intended to allow us to create flexible nested menu experiences without the overhead of managing their state; while this PR is large, most of that is demo, the actual components/compositions themselves should be fairly straightforward.
While I'd like to merge/release these, I'm still working on live versions so may revisit some functionality. One dev ex piece I'd already like to include (but won't in this PR) is for panel components to emit
closeevents that callers can listen to, to do something like:@close="openPanelById('some-next-panel')without needing to either listen to a nested v-model or watch a panel.