Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CONTRIBUTION.md, changed code style to PEP8, docstring style to… #27

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

Prayag2
Copy link
Owner

@Prayag2 Prayag2 commented Mar 10, 2021

Changes

Additions

  • Added a CONTRIBUTION.md

Fixes

  • Fixed a possible bug. Refer to #26.

@Prayag2 Prayag2 requested a review from majabojarska March 11, 2021 12:12
@Prayag2
Copy link
Owner Author

Prayag2 commented Mar 12, 2021

There was no response so I'm merging it :(

@Prayag2 Prayag2 merged commit 1be054c into master Mar 12, 2021
@majabojarska majabojarska deleted the change_code_style branch March 13, 2021 16:19
@majabojarska
Copy link
Collaborator

Hi @Prayag2, I declared that I would look at the projects on the weekends. You requested me as a reviewer. I would look into the changes right now, but don't expect responses from me on workdays.

About the changes:

  • Python compiled (*.pyc) files are temporary files generated by the interpreter. Those shouldn't be added nor tracked by version control systems. Not sure how they got commited, since those are gitignored (force add?). I'll revert this today.
  • CONTRIBUTION.md looks great.
  • Minor stuff like missing newline at end of file, but I'll handle that.

@Prayag2
Copy link
Owner Author

Prayag2 commented Mar 13, 2021

Oh, I'm sorry! I forgot that you are busy on workdays.

Python compiled (*.pyc) files are temporary files generated by the interpreter. Those shouldn't be added nor tracked by version control systems. Not sure how they got commited, since those are gitignored (force add?). I'll revert this today.

I was thinking about this too! I don't know why but the __pycache__ folder is getting tracked too.

Minor stuff like missing newline at end of file, but I'll handle that.

okay thanks!

@majabojarska
Copy link
Collaborator

majabojarska commented Mar 13, 2021

I was thinking about this too! I don't know why but the pycache folder is getting tracked too.

Probably was added some time ago and wasn't removed from Git history. Fixed this in #30 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants