Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Mocha Test Explorer Integration #4518

Merged
merged 12 commits into from
Apr 14, 2023
Merged

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented Apr 14, 2023

PR Summary

Consolidates the RunTests entrypoint to work with both direct debugging and the Mocha Test Explorer vscode extension.
image
image

Other fixes:

  • Moves launch workspace configs from code-workspace into the vscode-powershell folder (required for test explorer integration)
  • Move common mocha configuration out to separate configuration file
  • Eliminates the separate launch/attach configs and unifies them into a single config.
  • Re-enables ANSI output for Azure Devops test output
  • Refactor runtests/index to runtests/runtestsinner, and provide more clarity as to what is going on
  • Move some workspace config comments to be inline with their setting so they are more portable
  • Add slow and timeout indicators to several tests to suppress their warnings about their normally slow runtime

Limitation

The "debug test" button in the explorer may occasionally not hit a breakpoint due to a race condition between the debugger attaching and the test explorer attaching for debug. I have requested a fix be made to resolve this, for now it's best to click the "debug all" button when debugging tests rather than debug individual.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@JustinGrote JustinGrote requested a review from a team April 14, 2023 03:26
@JustinGrote JustinGrote requested a review from a team as a code owner April 14, 2023 03:26
@JustinGrote JustinGrote enabled auto-merge (squash) April 14, 2023 03:26
@JustinGrote JustinGrote self-assigned this Apr 14, 2023
test/runTests.ts Fixed Show resolved Hide resolved
test/utils.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
test/utils.ts Show resolved Hide resolved
test/features/UpdatePowerShell.test.ts Show resolved Hide resolved
extension-dev.code-workspace Outdated Show resolved Hide resolved
test/runTestsInner.ts Outdated Show resolved Hide resolved
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Build & Release labels Apr 14, 2023
@JustinGrote JustinGrote merged commit 9bca90a into main Apr 14, 2023
@JustinGrote JustinGrote deleted the feature/mocha-test-explorer branch April 14, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants