-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Extension Authoring Experience with new Build Tasks and Launch Configs #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… imports rather than "* as" syntax
andyleejordan
requested changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Co-authored-by: Andy Jordan <2226434+andschwa@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andschwa@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andschwa@users.noreply.github.com>
andyleejordan
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates the build tasks and launch configs to:
Testing
Open the workspace file
Run ./build at least once (integrated PSES watch builds and auto-attach debugging is future PR)
Click the
Test Extension
Launch Task and note the vscode instance that starts does not use your personal settingsClick the
Launch Extension
Task and note the launched extension has your settings. First run may take a while but future starts should be near-instant. Also note that there are watch tasks now running for both tests files and build files and will auto-update every time you save a change and have a status indicator to the right.Click the
Launch Extension - Isolated Profile
task and note the vscode window is isolated. Change your theme and launch again, observe that theme persisted but did not change developer's personal settings.Repeat with
Launch Extension - Temp
but note the theme change does not persist.Insert an intentional error into a .ts file and try to run a launch config. An error will appear saying that errors ocurred and will take you straight to the errors.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready