Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pester code lense #2606

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Conversation

nohwnd
Copy link
Contributor

@nohwnd nohwnd commented Apr 3, 2020

PR Summary

The settings was renamed before release, and the name was not updated in the settings description.

Fixes #2603

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@nohwnd
Copy link
Contributor Author

nohwnd commented Apr 3, 2020

@TylerLeonhardt you missed one place when renaming it from Enable to Use. Not sure how we would test for that.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nohwnd
Copy link
Contributor Author

nohwnd commented Apr 6, 2020

@TylerLeonhardt Any idea when this will ship? I am nearing Pester 5 release, and would like this to be in good shape 🙂

@TylerLeonhardt
Copy link
Member

It'll be in a preview that'll go out this week and then in a stable release probably the week after

@TylerLeonhardt TylerLeonhardt merged commit 01ac857 into PowerShell:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Preview-2020.3.2] Enable Legacy Code Lens not working
2 participants