Allow debugging in interactive session with no dir change #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1330 This PR depends on a corresponding PR to PSES to have it handle null/empty string differently in the non-temp console case. For the generateLaunchConfig case, we now pass "" as cwd to PSES. That tells PSES to not change the directory *if* we aren't running in a temp console. If we are in a temp console, then use old logic to set working dir. Update "PowerShell Interactive Session" debug config to tell PSES to not change the working dir. Remove "program" field from launch config. This has been marked deprecated for over a year now. Change refs in ${workspaceRoot} to ${workpaceFolder} to work better in a multi-workspace environment. Remove unused imports/field in DebugSession.ts.
rjmholt
approved these changes
Jul 2, 2018
|
Great! I'll merge this after I have addressed feedback on the corresponding PSES PR. |
|
We'll need to remember to call this out as a breaking change 👍 |
rjmholt
pushed a commit
that referenced
this pull request
Jul 11, 2018
Fix #1330 This PR depends on a corresponding PR to PSES to have it handle null/empty string differently in the non-temp console case. For the generateLaunchConfig case, we now pass "" as cwd to PSES. That tells PSES to not change the directory *if* we aren't running in a temp console. If we are in a temp console, then use old logic to set working dir. Update "PowerShell Interactive Session" debug config to tell PSES to not change the working dir. Remove "program" field from launch config. This has been marked deprecated for over a year now. Change refs in ${workspaceRoot} to ${workpaceFolder} to work better in a multi-workspace environment. Remove unused imports/field in DebugSession.ts.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1330
This PR depends on a corresponding PR to PSES to have it handle
null/empty string differently in the non-temp console case.
For the generateLaunchConfig case, we now pass "" as cwd to PSES.
That tells PSES to not change the directory if we aren't running
in a temp console. If we are in a temp console, then use old logic to
set working dir.
Update "PowerShell Interactive Session" debug config to tell PSES
to not change the working dir.
Remove "program" field from launch config. This has been marked
deprecated for over a year now.
Change refs in ${workspaceRoot} to ${workpaceFolder} to work
better in a multi-workspace environment.
Remove unused imports/field in DebugSession.ts.
PR Summary
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready