Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tslint rule file-header to enforce copyright in TS files #1396

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

rkeithhill
Copy link
Contributor

I would like to add a "fix" string which this page says is supported:
https://palantir.github.io/tslint/rules/file-header/

But the comment style of the fix doesn't follow our style and is
apparently not configurable e.g.:

/*!
 * <copyright fix line>
 */

Fix #1394

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

I would like to add a "fix" string which this page says is supported:
https://palantir.github.io/tslint/rules/file-header/

But the comment style of the fix doesn't follow our style and is
apparently not configurable.
```
/*!
 * copyright line
 */
```
Fix #1394
@rkeithhill rkeithhill requested a review from TylerLeonhardt July 1, 2018 22:37
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄 Thanks for adding this Keith

@TylerLeonhardt TylerLeonhardt merged commit 8d65def into master Jul 2, 2018
@TylerLeonhardt TylerLeonhardt deleted the rkeithhill/add-fileheader-tslint-rule branch July 2, 2018 21:44
rjmholt pushed a commit that referenced this pull request Jul 11, 2018
I would like to add a "fix" string which this page says is supported:
https://palantir.github.io/tslint/rules/file-header/

But the comment style of the fix doesn't follow our style and is
apparently not configurable.
```
/*!
 * copyright line
 */
```
Fix #1394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSLint should enforce license headers
3 participants