Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue w/launch config not using the temp integrated console setting #1225

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

rkeithhill
Copy link
Contributor

This ensures we pass the correct value to PSES so that it won't exit the temp console after execution.

@rkeithhill rkeithhill requested a review from daviwil March 11, 2018 01:24
@rkeithhill
Copy link
Contributor Author

rkeithhill commented Mar 11, 2018

BTW I notice that the "attach" debug request honors createTempIntegratedConsole as well. Is that the idea? Right now, the [TEMP] PSIC window will not stick around in the attach scenario. I'm thinking this is probably alright for attach. If folks complain, we can add support for this later. Right now, the attach debug request doesn't even define the createTempIntegratedConsole field. Thoughts?

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@TylerLeonhardt
Copy link
Member

I'm fine with that for attach.

One of the bugs I ran into was for running a script while remoted into another machine. Since createTempIntegratedConsole was not set in the launch config, the whole experience was kinda messed up:
A temp console was created and disappeared and it wouldn't be the same remote session it would be a new session.

I believe this PR fixes the issue I was having though. This issue might be reason to have a 1.6.1 release.

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt March 19, 2018 22:52
@rkeithhill rkeithhill merged commit 6c1e30e into master Mar 20, 2018
@rkeithhill rkeithhill deleted the rkeithhill/fix-temp-int-console-issue branch March 20, 2018 00:35
@rkeithhill rkeithhill added this to the 1.6.1 milestone Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants