vscode-powershell / scripts / Install-VSCode.ps1 $IsLinux failure

[codykonior]

System Details

• Operating system name and version: Server 2012 R2
• VS Code version: None
• PowerShell extension version: None
• Output from $PSVersionTable: Name Value

---

PSVersion 5.1.14409.1012
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.14409.1012
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Issue Description

Installing using the script:

PS C:\Users\XXX> Install-Script Install-VSCode -Scope CurrentUser; Install-VSCode.ps1

C:\Users\XXX\Documents\WindowsPowerShell\Scripts\Install-VSCode.ps1 : The variable '$IsLinux' cannot be retrieved because it has not been set.
At line:1 char:51

• Install-Script Install-VSCode -Scope CurrentUser; Install-VSCode.ps1

•                                               ~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidOperation: (IsLinux:String) [Install-VSCode.ps1], RuntimeException
  • FullyQualifiedErrorId : VariableIsUndefined,Install-VSCode.ps1

This is because StrictMode is on, and you're checking a variable that doesn't exist. It's best practice to do checking of variables in a way that doesn't trigger errors.

[TylerLeonhardt]

This check for $IsLinux in a "truthy" way should be changed to:

Test-Path variable:IsLinux

[michaelschulz]

$IsLinux is available in PS 6. The sript itself (at this point) doesn't support installation on Linux, so what's the point of switching the $Architecture to either 64-bit or 32-bit if an OS that's not supported by this script is detected?

[dsolodow]

It doesn't; it only does that check if the OS is Windows.
Did you perhaps miss the ! in if (!($IsLinux -or $IsOSX)) ?
It would have been more readable to make it if (-not($IsLinux -or $IsOSX))

[michaelschulz]

No, I did see the !. What I was wondering was why even check for that if there's no support to install on anything but Windows? Looking into a way to implement for Linux.

[dsolodow]

Ah. Well, the bitness check only occurs for Windows; Linux and OSX go to the "write-error' at the end. For Linux support, would probably have to add some checks for distro, version and bitness to grab the right package/repo. Sent from mobile

…

On Wed, Mar 21, 2018, 10:47 AM Michael Schulz ***@***.***> wrote: No, I did see the !. What I was wondering was why even check for that if there's no support to install on anything but Windows? Looking into a way to implement for Linux. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#996 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHOSOjkOxH3zOSokb3ovfwWDsGLsDhx3ks5tgmflgaJpZM4O3GVC> .

[michaelschulz]

Correct, plus a decision whether to do a direct install from package or add repo and then install from there which would probably be the preferred way in order to keep the system up to date.

[TylerLeonhardt]

If folks use a certain distro of linux, they're more than welcome to submit a PR with an automated installation for that distro 😃 same goes for macOS.