-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger crashes after multiple runs. #273
Comments
Hey @antonyoni, can you zip up the following folder and e-mail it to me,
Thanks! |
Could be related to this issue: #243 |
I experience the same bug, I'll send you my logs. |
I've just sent the logs. I also noticed some strange behaviour where not all expected output is showing in the Debug Console. If I run the following:
I get nothing in the output console. Uncommenting the warning still produces nothing. If the warning and error are uncommented, then I get everything including the error, but not "line 2". Stdout not getting flushed? I don't think this was happening with 0.6.1. Not sure if it's related to PowerShellEditorServices#138 |
@antonyoni I've seen this as well on 0.7.1. If you set a breakpoint on line 1 and step over it, you'll see its output. But when you step over the last line, you probably won't - at least I don't. Seems like a flushing issue as you will see the outputting while stepping but if the script executes fast enough, there is no output. |
I'm experiencing the same issue on the same config, although it's been like that for me since 0.7.0. |
Thanks for sending your logs, guys, I am looking at them now. @antonyoni: You're right, the output issue is related to the one you found. Need to investigate that as well. |
I think I fixed the problem! Filed an issue on the PowerShellEditorServices repo to track it: PowerShell/PowerShellEditorServices#284 New release with the fix within 24 hours! |
This change fixes an issue in PowerShellContext.AbortException which causes it to throw a NullReferenceException when called after the session has already been aborted. This issue manifests sometimes when the debug adapter finishes execution normally or when it terminates due to a script parsing error. It was initially reported in the following two issues for the PowerShell VS Code extension: PowerShell/vscode-powershell#243 PowerShell/vscode-powershell#273 The fix is to check whether the PowerShellContext.SessionState is Aborted or Disposed before proceeding with the abort.
Why isn't 0.6.2 on the releases page? |
Sometimes I just forget to do it :/ For this release I'm going to put together a script to automate the release uploads on GitHub so that they're always available. |
@daviwil that's fixed it - haven't had to restart vscode yet today. thanks! |
Excellent, thanks a lot for confirming! Please let me know if you hit another crash, I've added some additional logging which should help diagnose future issues. |
Versions:
VSCode: 1.4.0
OS: Windows 10.1607
Extension: 0.7.1
After running the debugger multiple times, there is a 'powershell has stopped working' error:
and the following in the Console:
Once this happens I get a 'Debuger adapter process has terminated unexpectedly' error when debugging further:
This issue occurs on two separate machines with the same versions of everything. Only started happening after update to extension version 0.7.1.
Can be fixed by restarting vscode.
The text was updated successfully, but these errors were encountered: