Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extension and PSES to handle PS Core rename of binary to pwsh #1064

Closed
rkeithhill opened this issue Oct 22, 2017 · 1 comment · Fixed by #1071
Closed

Update extension and PSES to handle PS Core rename of binary to pwsh #1064

rkeithhill opened this issue Oct 22, 2017 · 1 comment · Fixed by #1071

Comments

@rkeithhill
Copy link
Contributor

Title says it all. This one will be a bit tricky since we support side-by-side PS Core installations. We can't wholesale change powershell to pwsh - just for PS Core 6.0.0-beta.9 and higher. Do we already have an npm package pulled in that can compare semver v2 versions?
@daviwil
Copy link
Contributor

daviwil commented Oct 23, 2017

Maybe just keep it simple and look for either powershell.exe or pwsh.exe in the PowerShell Core install paths?

rkeithhill added a commit to rkeithhill/vscode-powershell that referenced this issue Oct 26, 2017
@rkeithhill
Update to handle PS Core binary name change
8d3ff45 
Fix PowerShell#1064

Also fixes case where the powerShellExePath setting is no longer valid.  This happens when a Windows users installs an updated pre-release version of PS Core.  That uninstalls previous versions.
@rkeithhill rkeithhill mentioned this issue Oct 26, 2017
Merged
daviwil pushed a commit that referenced this issue Oct 26, 2017
@rkeithhill @daviwil
Update to handle PS Core binary name change
a70a499 
Fix #1064

Also fixes case where the powerShellExePath setting is no longer valid.  This happens when a Windows users installs an updated pre-release version of PS Core.  That uninstalls previous versions.
@daviwil daviwil mentioned this issue Oct 26, 2017
Closed
@mrward mrward mentioned this issue Dec 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to handle PS Core binary name change rkeithhill/vscode-powershell
2 participants
@daviwil @rkeithhill