-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default parameter values should be 'none' not 'false' #167
Comments
@jdhitsolutions thanks, that looks like a good catch. @vors any thing you want to add before I pick this up? |
Of course a Switch should still have a default value of false. |
Good catch. I know for sure, it used to be the case at some point. Surprised it became broken in 0.5.0. We definitely need a test for that. |
@jdhitsolutions |
Solution: 1.Set the default value of "None" in Markdown2Renderer class when call New-Markdownhelp 2.Meanwhile update the hard cord to ensure generate maml help file with False from "SwitchParamter" conversion when call Nex-ExternalHelp.
Yingda/#167: Platyps - Default parameter values should be 'none' not 'false'
resolved in #199 |
Steps to reproduce
Create markdown file from any PowerShell function that has a parameter with no default value.
Expected behavior
When looking at parameter details the setting for Default value should be set to none.
Actual behavior
The Default value is being set to False.
Environment data
v0.5.0
The text was updated successfully, but these errors were encountered: