Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default parameter values should be 'none' not 'false' #167

Closed
jdhitsolutions opened this issue Jul 8, 2016 · 5 comments
Closed

Default parameter values should be 'none' not 'false' #167

jdhitsolutions opened this issue Jul 8, 2016 · 5 comments
Assignees
Milestone

Comments

@jdhitsolutions
Copy link

Steps to reproduce

Create markdown file from any PowerShell function that has a parameter with no default value.

Expected behavior

When looking at parameter details the setting for Default value should be set to none.

Actual behavior

The Default value is being set to False.

Environment data

v0.5.0

@jongeller
Copy link
Contributor

@jdhitsolutions thanks, that looks like a good catch.

@vors any thing you want to add before I pick this up?

@jongeller jongeller self-assigned this Jul 10, 2016
@jdhitsolutions
Copy link
Author

Of course a Switch should still have a default value of false.

@vors
Copy link
Collaborator

vors commented Jul 11, 2016

Good catch. I know for sure, it used to be the case at some point. Surprised it became broken in 0.5.0. We definitely need a test for that.

@vors vors added the bug label Jul 11, 2016
@sankethka sankethka added this to the 0.7.0 milestone Jul 20, 2016
@jongeller
Copy link
Contributor

@jdhitsolutions
we started working on this, could not repro. Could you give us the steps where you encountered this?

YingdaBeyondsoft added a commit to YingdaBeyondsoft/platyPS that referenced this issue Aug 30, 2016
Solution:
1.Set the default value of "None" in Markdown2Renderer class when call
New-Markdownhelp
2.Meanwhile update the hard cord to ensure generate maml help file with
False from "SwitchParamter" conversion when call Nex-ExternalHelp.
jongeller added a commit that referenced this issue Aug 30, 2016
Yingda/#167: Platyps - Default parameter values should be 'none' not 'false'
@jongeller
Copy link
Contributor

resolved in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants