Fix of issue 750 and 756 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagajjal
reviewed
Jun 5, 2017
| $idRefShortValue = ($a.IdentityReference.Value).split('\')[-1] | ||
| if ($idRefShortValue -in $specialIdRefs ) | ||
| { | ||
| $ruleIdentity = Get-UserSID -User (New-Object Security.Principal.NTAccount $idRefShortValue) |
There was a problem hiding this comment.
since this logic is duplicated in two places.. better to create a internal method so that it can be expanded in future as and when we run into this kind of exceptions... Its easy to maintain if its in one place..
There was a problem hiding this comment.
They are similar, but not same. Wrapping them in a function does not save code lines and need at least 6 parameters. plus need a logic in caller to call continue if wrapping them in function.
bagajjal
approved these changes
Jun 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerShell/Win32-OpenSSH#750
PowerShell/Win32-OpenSSH#756