Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add traits for folding tests #837

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

glennsarti
Copy link
Contributor

This commit adds trait attributes to the Code Folding tests, to make development
faster by making it possible to run only a subset of tests.

This commit adds trait attributes to the Code Folding tests, to make development
faster by making it possible to run only a subset of tests.
@glennsarti glennsarti requested a review from rjmholt as a code owner December 21, 2018 08:08
@TylerLeonhardt
Copy link
Member

Sorry as I haven't used Traits before. Can you explain how the CI will be set up to run only the traits that matter? And how we can fire a full build?

@glennsarti
Copy link
Contributor Author

CI would not be affected. by default all tests are run.

@glennsarti
Copy link
Contributor Author

But for development, to only run the folding tests;

Invoke-Build TestServer -TestFilter "Category=Folding"

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt TylerLeonhardt merged commit 10fc0f7 into PowerShell:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants