Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update various NuGet packages #829

Merged
merged 5 commits into from
Jan 11, 2019
Merged

Update various NuGet packages #829

merged 5 commits into from
Jan 11, 2019

Conversation

bergmeister
Copy link
Contributor

No description provided.

@bergmeister bergmeister requested a review from rjmholt as a code owner December 15, 2018 15:30
rjmholt
rjmholt approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The Newtonsoft.Json thing in PowerShell always makes me worry, but the only worry I would have here is for Serilog and I don't think we can honestly promise to never upgrade it in case people are running something depending on it within PSES.

rkeithhill
rkeithhill approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergmeister
Copy link
Contributor Author

bergmeister commented Jan 8, 2019 •
edited
Loading

Thanks for upstreaming my branch @TylerLeonhardt . I also updated the System.IO.Pipes.AccessControl NuGet package from 4.5.0 to 4.5.1 today.
P.S. (on an unrelated note): Today I managed to build and test the vs-code ps extension together with my other PSES and my PSSA branches to validate my 3 other vscode-powershell/PSES PRs end to end as they all depend on each other, we will have to wait with the merge though until PSSA 1.18 gets released to the public in a few weeks (hopefully) as those will be using new features.

@TylerLeonhardt TylerLeonhardt merged commit e9445d9 into PowerShell:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@rkeithhill rkeithhill rkeithhill approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bergmeister @rkeithhill @rjmholt @TylerLeonhardt