Fix inner help completion

[rjmholt]

Fixes PowerShell/vscode-powershell#1509.

I'm not sure what the added lines ?? part of the comment based help request handler was trying to achieve, but I don't think it was correct. So I've removed that.

My second commit refactors the method body a bit to make it a bit simpler.

[SeeminglyScience]

LGTM

[rkeithhill]

As long as this still works for the "complete doc comment help before the function" case, it LGTM.

[TylerLeonhardt]

LGTM

[rjmholt]

@rkeithhill I did try the help completions both before and after the function for this PR. Are there any other cases I should try? We should also test on Windows

[rjmholt]

Ok I've tested now!

[darksidemilk]

Is there any sort of expected release date for when this fix will be available to end users?
Or is there a way I could compile the extension myself to get this functionality back before then?

[TylerLeonhardt]

We're shooting for later this week. You could also grab the VSIX (not the v2 one - v2 is PSReadLine) here:
https://ci.appveyor.com/project/PowerShell/vscode-powershell/build/artifacts

[rjmholt]

Before you grab that VSIX, let me make sure it's been rebuilt. Will post again here when it's done.

[rjmholt]

@darksidemilk Here's the link to the preview VSIX: https://ci.appveyor.com/api/buildjobs/20gp23hxqoi8gq4c/artifacts/PowerShell-insiders.vsix

[darksidemilk]

Is there some change to how it works, because at first I was going to report that it is not working. But then I noticed the release note about asynchronous processing and noted that the function I was adding documentation too has quite a few parameters. SO I added the ## to it and waited, went to go try it on a different machine came back and the help info was there at last. So It's kinda working but I feel like it shouldn't take 5-10 minutes to create it. Maybe there's something I'm doing that is causing it to hang?

[darksidemilk]

Is there some change to how it works, because at first I was going to report that it is not working. But then I noticed the release note about asynchronous processing and noted that the function I was adding documentation too has quite a few parameters. SO I added the ## to it and waited, went to go try it on a different machine came back and the help info was there at last. So It's kinda working but I feel like it shouldn't take 5-10 minutes to create it. Maybe there's something I'm doing that is causing it to hang?

Did a little more testing. It does work as expected when I installed the preview version on a different machine in a different script. So maybe this can hang when there are too many parameters defined in a function or something? In my particular situation it's in some functions I wrote before I truly understood how to use the param () section and was putting all the parameters and their default values there. Which I now know isn't the best approach and will just edit those functions a bit. But I imagine its possible to have 10+ parameters in a function with default values in them. Perhaps that is a condition that can cause help completion to hang?