Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a null dereference when an invalid cast exception has no inner exception #729

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Fix a null dereference when an invalid cast exception has no inner exception #729

merged 1 commit into from
Aug 27, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Aug 22, 2018

Fixes PowerShell/vscode-powershell#1450.

When a parameter causes an invalid cast exception in the console, we assumed the inner exception wasn't null. Now if it is, we pass through the outer exception.

TylerLeonhardt
TylerLeonhardt approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rkeithhill
rkeithhill approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkeithhill
Copy link
Contributor

Darn little niggly null bugs. I'm looking forward to trying out C# 8's non-nullable reference types (assuming the feature makes the cut). Maybe not in this project but somewhere. :-)

SeeminglyScience
SeeminglyScience approved these changes Aug 23, 2018
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit 5f44ba9 into PowerShell:master Aug 27, 2018
@rjmholt rjmholt deleted the fix-invalidcast-null-dereference branch December 12, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

@rkeithhill rkeithhill rkeithhill approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjmholt @rkeithhill @TylerLeonhardt @SeeminglyScience