Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OmniSharp #2079

Closed
wants to merge 3 commits into from
Closed

Update OmniSharp #2079

wants to merge 3 commits into from

Conversation

andyleejordan
Copy link
Member

Dependabot got confused when I updated the configuration and so it accidentally closed #2074 and then opened #2077, but this has the commits which gets the project building again with this update.

dependabot bot and others added 3 commits September 18, 2023 14:43
Bumps the omnisharp group with 4 updates: [OmniSharp.Extensions.LanguageServer](https://github.com/OmniSharp/csharp-language-server-protocol), [OmniSharp.Extensions.DebugAdapter.Server](https://github.com/OmniSharp/csharp-language-server-protocol), [OmniSharp.Extensions.LanguageClient](https://github.com/OmniSharp/csharp-language-server-protocol) and [OmniSharp.Extensions.DebugAdapter.Client](https://github.com/OmniSharp/csharp-language-server-protocol).


Updates `OmniSharp.Extensions.LanguageServer` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

Updates `OmniSharp.Extensions.DebugAdapter.Server` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

Updates `OmniSharp.Extensions.LanguageClient` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

Updates `OmniSharp.Extensions.DebugAdapter.Client` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

---
updated-dependencies:
- dependency-name: OmniSharp.Extensions.LanguageServer
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
- dependency-name: OmniSharp.Extensions.DebugAdapter.Server
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
- dependency-name: OmniSharp.Extensions.LanguageClient
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
- dependency-name: OmniSharp.Extensions.DebugAdapter.Client
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
...

Signed-off-by: dependabot[bot] <support@github.com>
By searching OmniSharp's diff for what changed, whee.
But it's throwing:

    [Error - 4:53:23 PM] OmniSharp.Extensions.JsonRpc.DefaultRequestInvoker: Failed to handle request initialize 0 - Newtonsoft.Json.JsonSerializationException: Error converting value True to type 'OmniSharp.Extensions.LanguageServer.Protocol.Supports`1[OmniSharp.Extensions.LanguageServer.Protocol.Client.Capabilities.SemanticTokensCapabilityRequestRange]'. Path 'textDocument.semanticTokens.requests.range', line 1, position 4679.
     ---> System.ArgumentException: Could not cast or convert from System.Boolean to OmniSharp.Extensions.LanguageServer.Protocol.Supports`1[OmniSharp.Extensions.LanguageServer.Protocol.Client.Capabilities.SemanticTokensCapabilityRequestRange].

The sample server still has this set to `true` and that should be valid,
but David has a conference demo that set it with this object. I don't
know. I can't find anything client-side to change.
@andyleejordan
Copy link
Member Author

Replaced with #2083

@andyleejordan andyleejordan deleted the andyleejordan/omnisharp-update branch December 15, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant