Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the TranscribeOnly bug (take three) #2031

Merged
merged 1 commit into from
May 30, 2023
Merged

Fix the TranscribeOnly bug (take three) #2031

merged 1 commit into from
May 30, 2023

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented May 30, 2023 •
edited
Loading

Yet again fixing compiler constants, just go this plain wrong last time. Also caught in testing that we need to disable TranscribeOnly in the finally of ExecuteDebugger too, so that the original Out-Default (from the invocation of the debugged script) isn't broken.

@andyleejordan andyleejordan requested a review from a team May 30, 2023 20:42
@andyleejordan andyleejordan force-pushed the andschwa/take-three branch from 9d87289 to 9bea6a9 Compare May 30, 2023 21:12
@andyleejordan andyleejordan enabled auto-merge (squash) May 30, 2023 21:12
@andyleejordan andyleejordan mentioned this pull request May 30, 2023
Closed
6 tasks
SeeminglyScience
SeeminglyScience approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 3451004 into main May 30, 2023
@andyleejordan andyleejordan deleted the andschwa/take-three branch May 30, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Extension Terminal Issue-Bug A bug to squash.
Projects
Flying Fox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SeeminglyScience