Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the TranscribeOnly bug (take two) #2026

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix the TranscribeOnly bug (take two) #2026

merged 2 commits into from
May 23, 2023

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented May 17, 2023 •
edited
Loading

We were using our own UI, not the byzantine internal UI where it actually needed to be fixed.

This is #2023 but again, with the right UI.

And not only have we tracked this down, we were finally able to reproduce it (and so test this fix).

Resolves PowerShell/vscode-powershell#3991.

@andyleejordan andyleejordan requested a review from a team May 17, 2023 19:10
@andyleejordan andyleejordan mentioned this pull request May 17, 2023
Closed
6 tasks
SeeminglyScience
SeeminglyScience approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan force-pushed the andschwa/fix-transcript-bug-take-two branch 2 times, most recently from 3d8f00c to 7ba4620 Compare May 18, 2023 01:38
@andyleejordan andyleejordan requested a review from a team as a code owner May 18, 2023 01:38
@andyleejordan andyleejordan force-pushed the andschwa/fix-transcript-bug-take-two branch from 7ba4620 to 53220a6 Compare May 18, 2023 02:25
@andyleejordan
Fix the TranscribeOnly bug (take two)
0e17030 
We were using our own UI, not the byzantine internal UI where it
actually needed to be fixed. Whole lot of reflection.

Also had to fix our `CoreCLR` compiler constant.
@andyleejordan andyleejordan force-pushed the andschwa/fix-transcript-bug-take-two branch from 53220a6 to 0e17030 Compare May 18, 2023 02:31
@andyleejordan
Copy link
Member Author

P.S. This is actually like take five.

SeeminglyScience
SeeminglyScience reviewed May 18, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some clean up. A normal invocation will be a virtual call so we'll get the override just fine thankfully.

src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs Outdated Show resolved Hide resolved
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs Outdated Show resolved Hide resolved
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs Outdated Show resolved Hide resolved
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs Outdated Show resolved Hide resolved
@andyleejordan @SeeminglyScience
Apply suggestions from code review
ec17160 
Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
@andyleejordan andyleejordan merged commit 759a88f into main May 23, 2023
@andyleejordan andyleejordan deleted the andschwa/fix-transcript-bug-take-two branch May 23, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Extension Terminal Issue-Bug A bug to squash.
Projects
Flying Fox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write-Output broken
2 participants
@andyleejordan @SeeminglyScience