Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to better document selecting #1218

Conversation

TylerLeonhardt
Copy link
Member

Trying to get the vim extension working, I noticed that the filetype for PowerShell files was ps1 instead of powershell.

This adds ps1 and a few others to our document selector.

I really should get the vim extension using powershell but it's harder than it sounds because any vim plugin can change this.

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt as a code owner March 5, 2020 20:29
@TylerLeonhardt
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 7
           

Complexity increasing per file
==============================
- src/PowerShellEditorServices/Utility/LspUtils.cs  1
         

Clones added
============
- src/PowerShellEditorServices/Services/TextDocument/Handlers/SignatureHelpHandler.cs  5
- src/PowerShellEditorServices/Services/TextDocument/Handlers/DocumentSymbolHandler.cs  2
- src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs  2
- src/PowerShellEditorServices/Services/TextDocument/Handlers/HoverHandler.cs  5
- src/PowerShellEditorServices/Services/TextDocument/Handlers/FormattingHandlers.cs  1
- src/PowerShellEditorServices/Services/TextDocument/Handlers/FoldingRangeHandler.cs  3
- src/PowerShellEditorServices/Services/TextDocument/Handlers/DocumentHighlightHandler.cs  1
- src/PowerShellEditorServices/Services/TextDocument/Handlers/DefinitionHandler.cs  2
         

See the complete overview on Codacy

@TylerLeonhardt TylerLeonhardt merged commit c005ef7 into PowerShell:master Mar 5, 2020
@TylerLeonhardt TylerLeonhardt deleted the switch-to-better-document-selecting branch March 5, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants