Fix PSES Commands module #1211
Merged
Fix PSES Commands module #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 27, 2020 09:56
…/PowerShellEditorServices into psescommands-types-fixes
added 2 commits
February 27, 2020 11:21
module/PowerShellEditorServices/Commands/Public/CmdletInterface.ps1
Outdated
Show resolved
Hide resolved
module/PowerShellEditorServices/Commands/Public/CmdletInterface.ps1
Outdated
Show resolved
Hide resolved
rjmholt
commented
Feb 29, 2020
module/PowerShellEditorServices/Commands/Public/CmdletInterface.ps1
Outdated
Show resolved
Hide resolved
module/PowerShellEditorServices/Commands/Public/CmdletInterface.ps1
Outdated
Show resolved
Hide resolved
SeeminglyScience
approved these changes
Feb 29, 2020
| @@ -3,7 +3,7 @@ Register-EditorCommand ` | |||
| -DisplayName 'Open Editor Profile' ` | |||
| -SuppressOutput ` | |||
| -ScriptBlock { | |||
| param([Microsoft.PowerShell.EditorServices.Services.PowerShellContext.EditorContext]$context) | |||
| param([Microsoft.PowerShell.EditorServices.Extensions.EditorContext, Microsoft.PowerShell.EditorServices]$context) | |||
There was a problem hiding this comment.
Does this syntax work with 5.1? I vaguely remember you running into issues where you needed the full qualification in 5.1. Or was it that the full qualification didn't work but this did?
There was a problem hiding this comment.
Ah good thinking! Now that you mention it, I remember a similar issue (with PSRL type invocation).
But I just tested it and this works in 5.1:
PS C:\Users\Robert Holt\Documents\Dev\sandbox> [microsoft.powershell.editorservices.extensions.editorcommand, microsoft.powershell.editorservices]
IsPublic IsSerial Name BaseType
-------- -------- ---- --------
True False EditorCommand System.Object
TylerLeonhardt
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2495