Fire and forget evaluate #1209
Merged
Fire and forget evaluate #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Feb 26, 2020
|
Oops, I wonder if I reintroduced this bug. |
|
Ok, doesn't seem to be reintroduced. Must have been fixed another way, as I definitely had reverted this code (since it didn't make sense and I didn't see a reason why it was like that...which is actually this PR lol). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2424
When you hit F8 in an interactive session that kicked the debugger on and stopped at a breakpoint, F8 would no longer work. This is because we were waiting for the original F8 to finish.
This changes the evaluate message to fire and forget which allows F8 to be run after the breakpoint is stopped.