Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PSSA settings discovery + pick up changes to settings file #1206

Merged
merged 11 commits into from
Feb 26, 2020
Merged

Fix PSSA settings discovery + pick up changes to settings file #1206

merged 11 commits into from
Feb 26, 2020

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Feb 25, 2020

@bergmeister
Copy link
Contributor

bergmeister commented Feb 25, 2020 •
edited
Loading

Some code comments but I can already confirm that this fixes the problem of not seeing PSSA warnings when there is no settings . Thanks for taking the time :-)

@rjmholt rjmholt marked this pull request as ready for review February 25, 2020 20:31
bergmeister
bergmeister reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, I can re-test tomorrow again if the fix is still working after the last commits if you want to?

@rjmholt
Copy link
Contributor Author

rjmholt commented Feb 25, 2020

I can re-test tomorrow again if the fix is still working after the last commits if you want to?

Yes please.

I've tested (and stepped through in the debugger) all the scenarios I could think of:

  • Default setting
  • Empty string
  • File not there
  • File deleted

But could always use more eyes

@rjmholt @TylerLeonhardt
Update src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs
7e53410 
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
@TylerLeonhardt
Copy link
Member

We don't need the FileSystemWatcher if we still check if the file exists on every invoke. Refactor to not have file watcher.

TylerLeonhardt
TylerLeonhardt approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bergmeister
bergmeister approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested with latest changes ✅

@rjmholt rjmholt merged commit cb9898a into PowerShell:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister bergmeister approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PSScriptAnalyzer not running when no settings file present
3 participants
@rjmholt @bergmeister @TylerLeonhardt